You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While using the table shorthand, if there is repeating data between two different columns/cells in the same row, then it triggers the react duplicate key warning. The row itself is given a key, but the cell is automatically generated by the content.
As far as I can tell this is a different issue than #1205 which was for the table row itself. It might be the same as #1030, but that was closed with the assumption that it was addressed by #599.
I am not sure if any of these took into the consideration the possibility of the data itself matching, so I thought it was important to report. If there is matching data on different rows, then the warning is not triggered.
Starting with the standard table example I modified the data slightly to have two of the data cells be an exact match.
Since the table cells within a row are siblings, I believe that the error itself is accurate. Can the automatically generated key possibly include the header row or something else that will ensure it is unique? This would allow for using the most basic option for renderBodyRow.
👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.
We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
I think on line 62 of TableRow.js, {_.map(cells, (cell) => TableCell.create(cell, { defaultProps: { as: cellAs } }))} is wrong.
This should have the defaultProps - key.
While using the table shorthand, if there is repeating data between two different columns/cells in the same row, then it triggers the react duplicate key warning. The row itself is given a key, but the cell is automatically generated by the content.
As far as I can tell this is a different issue than #1205 which was for the table row itself. It might be the same as #1030, but that was closed with the assumption that it was addressed by #599.
I am not sure if any of these took into the consideration the possibility of the data itself matching, so I thought it was important to report. If there is matching data on different rows, then the warning is not triggered.
Starting with the standard table example I modified the data slightly to have two of the data cells be an exact match.
Simplest form of renderBodyRow causes the duplicate key warning to appear:
If the content of the cell is modified then the error will not be triggered:
If both of the cells have the same content then again the warning is triggered:
Since the table cells within a row are siblings, I believe that the error itself is accurate. Can the automatically generated key possibly include the header row or something else that will ensure it is unique? This would allow for using the most basic option for renderBodyRow.
react 16.8.0
react-dom 16.8.0
semantic-ui-react 1.2.0
example created:
https://codesandbox.io/s/suir-table-shorthand-keys-2t2bt
The text was updated successfully, but these errors were encountered: