-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3: roadmap to release #4409
Comments
@layershifter what is the status user.React.forwardRef PR status? I see it is still in open |
@vinodhrajamuralidharan I had a conversation with @levithomason about that PR. The agreement was that he will review it and then we can proceed. I am also waiting for that PR to be merged π |
Is there any ETA on v3 progress @levithomason / @layershifter ? |
|
Thanks a lot @layershifter for the effort! |
See the roadmap: Semantic-Org/Semantic-UI-React#4409 See the breaking change: Semantic-Org/Semantic-UI-React#4286
Is there anything further that we can help test, in order to proceed with the v3 release? |
@layershifter could you please update the status? FYI @levithomason
|
1/2. Yes, it's relevant. I will update it to be more precise and detailed π |
@layershifter thank you for all you great work so far, highly appreciate your effort! This project is too good to just die, so I really hope someone wants to pick up from here. |
@DreierF it's indeed a bug, see #4432 for details.
@sunech @tourman I updated changelog and created migration guide (https://react.semantic-ui.com/migration-guide). I also updated issues that needs to be solved to release the next beta. Both issues contain action items and examples of changes needed to be done. Help on these issues is much appreciated π± |
@layershifter thanks for your work on this package, do you have approximate time when you plan to release 3.0 version? |
It fixes Please try and report issues π |
I can report that after making a few small changes all frontend unit tests of Quality-time pass with 3.0.0-beta.2: Test Suites: 85 passed, 85 total
Tests: 694 passed, 694 total
Snapshots: 0 total
Time: 67.751 s, estimated 70 s Most changes were needed because popups would not appear at the right position with 3.0.0-beta.2. Adding a span or div around triggers solved this. I can't reproduce this issue on the Semantic UI React documentation site so I guess it's an issue on our side. |
I don't think that it's worth creating a issue but the Sticky component didn't work after the upgrade. I needed to add |
This seems to also be an issue on our side. Started with the transition to beta.2 and adding a span around it indeed fixed it |
@layershifter - I fixed the first task in the beta-3 release. Could you please add issues for the rest of tasks in the list and I'll see if I can have a go at some of them? Would be nice to get v3 out! |
When is the v3 release scheduled for? |
Outside of the eventStack breaking change, it looks like it is just a lot of testing and documentation for the 3.0.0 beta 3 release. I'm not sure if @layershifter is taking pull requests, but maybe some in the community can assist. |
Yep, if somebody is brave enough to get rid of |
@layershifter Would you consider just going with the current state as version 3 and then working on the rest as version 4? Only reason is that so many people are getting the Just a thought, unless someone is about there on EventStack. |
@triemstr I am up to looking into the EventStack however there might be one more thing blocking the release that needs to be fixed: https://github.com/Semantic-Org/Semantic-UI-React/pull/4233/files#r1837715017 |
@layershifter So few past days, I've been looking into the EventStack in the Modal (and source code of the event-stack) and there is the thing "eventPool". As I think that I understand that it might help keeping multiple references to same callback (I imagine some independent unsubscribing), I can't really see the real purpose of it (or what and if something would break after removing it). Could you possibly give me some hint or direction or use case where it's necessary? |
This PR tracks work for Semantic UI React v3 π
Pre beta-0 β
ta-scripts
withrelease-it
For beta-0 β
Ref
component chore(Ref): remove componentΒ #4286Visibility
component chore(Visibility): remove componentΒ #4257Input
,Button
&TextArea
are forwarding refs to native elementsTransition
static props chore(TransitionGroup): use React.forwardRef()Β #4266Post beta-0 β
For beta-2 β
.defaultProps
FormInput: Support for defaultProps will be removed [v3]Β #4426, see FormInput: Support for defaultProps will be removed [v3]Β #4426 (comment)ref
forwarding Improve typings [v3]Β #4432, see Improve typings [v3]Β #4432 (comment)For beta-3
Tab.Pane
is missingΒ #4457eventStack
validateTrigger
should handleforwardRef
.displayName
in productionuse
)For RC
After release
The text was updated successfully, but these errors were encountered: