Pass props and other data separately into all component callbacks #4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
skondrashov
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4465 +/- ##
==========================================
- Coverage 99.50% 99.50% -0.01%
==========================================
Files 186 186
Lines 3465 3464 -1
==========================================
- Hits 3448 3447 -1
Misses 17 17 ☔ View full report in Codecov by Sentry. |
|
ACK on this, I won't be able to check this in upcoming two weeks, but I will follow up later. Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4464
All callbacks to components which need to process some internal value of the component have had to pull the data out of the object intended to mirrors the props that were passed into the component back to the parent. This PR separates those concepts, so that the callbacks receive internal values of components as separate parameters from the props object.
These are clearly breaking changes but they make the API cleaner and make it possible to see what values (including their types) the callbacks.
To make them easier to review, the changes are broken up into commits by each component which needed to be updated. All tests pass locally after every commit.