Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: [Popup] doesn't take into account popper's attributes, only styles #4488

Open
vkramskikh opened this issue Jul 24, 2024 · 1 comment
Open

Comments

@vkramskikh
Copy link

Bug Report

state.attributes.popper aren't applied to the popup wrapper div, only state.styles.popper are.

Steps

  1. Use Popup component with default props and modifiers (which include hide by default) and on="click".
  2. Open the popup by clicking the trigger.
  3. Scroll the trigger out of the viewport.

Expected Result

The popup wrapper div gets the attributes data-popper-escaped and data-popper-reference-hidden from the default hide modifier.

Actual Result

No attributes are added to the div.

Version

2.1.5

@layershifter layershifter changed the title SUIR's Popup.js doesn't take into account popper's attributes, only styles bug: [Popup] doesn't take into account popper's attributes, only styles Nov 12, 2024
@yamunajayan

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants