Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropShadowFilter does not work with InstancedGeometry #3

Open
Ali-RS opened this issue Jul 18, 2023 · 0 comments
Open

DropShadowFilter does not work with InstancedGeometry #3

Ali-RS opened this issue Jul 18, 2023 · 0 comments

Comments

@Ali-RS
Copy link

Ali-RS commented Jul 18, 2023

Hi,

For instanced geometries, no shadow is rendered under the objects.

in the below line

for( int i = 0; i < size; i++ ) {
Geometry g = casters.get(i);

perhaps we should check if the geometry is an InstancedGeometry and then check its instance list as well.

if (g instanceof InstancedGeometry ig) {
     for (Geometry instance : ig.getGeometries()) {
          // process instance 
     }
}
@Ali-RS Ali-RS changed the title DropShadowFilter does not support InstancedGeometries DropShadowFilter does not work with InstancedGeometry Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant