Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map does not work for exact addresses #22

Open
eugene-shramko opened this issue Jul 26, 2019 · 0 comments
Open

Map does not work for exact addresses #22

eugene-shramko opened this issue Jul 26, 2019 · 0 comments
Labels

Comments

@eugene-shramko
Copy link

Preconditions

Magento Version: 2.3.1 (Commerce)
Module Map Version: 1.1.6 (in addition to store locator extension)
Environment: Production mode
Configured provider: Google Maps

Steps to reproduce

  1. Go to stores page.
  2. Put not exact address related to the list of markers and click "Search".
    For instance, "Midland Highway, Kempton TAS, Australia"
  3. Check map behavior.
  4. Put exact address related to the list of markers and click "Search".
    For instance, "3121 Midland Highway, Kempton TAS, Australia"
  5. Check map behavior.

Expected result

The map is moved to corresponding area and related markers are displayed for both 3 & 5 steps.

Actual result

  • The map is moved to corresponding area and related markers are displayed for step 3.
  • The map is reset for step 5, all markers are displayed.

It looks like the extension expects to retrieve geometry.bounds for every result from Google Maps API during geocoding. In some cases it is not present, so the map is reset according to the current implementation. Probably geometry.viewport data could be used instead or as a fallback.

@Fdec Fdec added the bug label Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants