Skip to content
This repository has been archived by the owner on Apr 19, 2022. It is now read-only.

Lowercase all Slack IDs for make MXIDs more pretty on Matrix side #108

Open
MurzNN opened this issue Jan 14, 2021 · 5 comments
Open

Lowercase all Slack IDs for make MXIDs more pretty on Matrix side #108

MurzNN opened this issue Jan 14, 2021 · 5 comments

Comments

@MurzNN
Copy link
Contributor

MurzNN commented Jan 14, 2021

On Slack web interface - channel's and user's id looks good, like:
https://xxx.slack.com/client/T9SH61KC3/C9TFEAH9U
https://xxx.slack.com/client/T9SH61KC3/C9SH6NQ4B/user_profile/U9TFEAEDC
https://xxx.slack.com/team/U9TFEAEDC

But on Matrix side they contains too much underscores, here is example of /client/T9SH61KC3/C9TFEAH9U channel:

#_slackpuppet___t9_s_h61_k_c3=2d_c9_s_l_x_u_j02:homeserver.org

and same - for puppeted users:

@_slackpuppet___t9_s_h61_k_c3=2d_u_s_l_a_c_k_b_o_t:homeserver.org

Slack seems using case-insensitive id of usernames, channels, threads, etc, and simply uppercase them in frontend. So we can boldly lowercase all Slack ids on mx-puppet-slack side before sending to mx-puppet-bridge, for make them looks more pretty on Matrix side, like:

#_slackpuppet__t9sh61kc3=2dc9slxuj02:homeserver.org
#_slackpuppet__t9sh61kc3=2dslackbot:homeserver.org

For not broke old instances, we can make this optional, disabled by default.
What do you think about this idea?

@MurzNN MurzNN changed the title Lowercase the Slack id's for make user's mxid more pretty on Matrix side Lowercase all Slack IDs for make user's mxid more pretty on Matrix side Jan 14, 2021
@MurzNN MurzNN changed the title Lowercase all Slack IDs for make user's mxid more pretty on Matrix side Lowercase all Slack IDs for make MXIDs more pretty on Matrix side Jan 14, 2021
@auscompgeek
Copy link

AFAIK these IDs are uppercased on the backend, not the frontend.

@Sorunome
Copy link
Owner

Soru does not think this is worth it. It is not only a breaking change for all existing installs, but clients should make it so that you never have to use the mxid of someone, so the mxid should not matter. It could be a uuidv4 for all we know

@MurzNN
Copy link
Contributor Author

MurzNN commented Jan 17, 2021

It is not only a breaking change for all existing installs

I understand this, so this option can be added disabled by default, and with large red blinking warning, that must not be changed on existing installs.

but clients should make it so that you never have to use the mxid of someone

In ideal world - should, but in current world I see this ugly timeline in Element-Android:
image

P. S. In Element-Web all looks well.

@Sorunome
Copy link
Owner

Sorunome commented Jan 17, 2021 via email

@tchapi
Copy link

tchapi commented Jan 22, 2021

A configuration would be awesome for this! 🎉

In all clients (even Element), visiting the profile of a user displays this ugly-and-with-too-many-unecessary-underscores handle. Dropping the underscores would really make it more pleasant to the eye (and avoid bizarre line breaks on standard screen sizes, too)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants