This repository has been archived by the owner on Apr 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 25
Lowercase all Slack IDs for make MXIDs more pretty on Matrix side #108
Comments
MurzNN
changed the title
Lowercase the Slack id's for make user's mxid more pretty on Matrix side
Lowercase all Slack IDs for make user's mxid more pretty on Matrix side
Jan 14, 2021
MurzNN
changed the title
Lowercase all Slack IDs for make user's mxid more pretty on Matrix side
Lowercase all Slack IDs for make MXIDs more pretty on Matrix side
Jan 14, 2021
AFAIK these IDs are uppercased on the backend, not the frontend. |
Soru does not think this is worth it. It is not only a breaking change for all existing installs, but clients should make it so that you never have to use the mxid of someone, so the mxid should not matter. It could be a uuidv4 for all we know |
that is an issue in element android not handling replies correctly. please open an issue with them
17. 1. 2021 20:35:52 Alexey Murz Korepov <[email protected]>:
…> It is not only a breaking change for all existing installs
>
I understand this, so this option can be added disabled by default, and with large red blinking warning, that must not be changed on existing installs.
> but clients should make it so that you never have to use the mxid of someone
>
In ideal world - should, but in current world I see this ugly timeline in Element-Android:
[https://user-images.githubusercontent.com/336662/104853753-eff51880-5913-11eb-80db-9bf4c8646a03.png][image][https://user-images.githubusercontent.com/336662/104853753-eff51880-5913-11eb-80db-9bf4c8646a03.png]
P. S. In Element-Web all looks well.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub[#108 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AASSEVERKSKGQXDN66ECGEDS2M3ZNANCNFSM4WCQKULQ].
[data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEgAAABICAYAAABV7bNHAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAArSURBVHic7cEBDQAAAMKg909tDjegAAAAAAAAAAAAAAAAAAAAAAAAAAA+DFFIAAEctgHwAAAAAElFTkSuQmCC###24x24:true###][Sledovací obrázek][https://github.com/notifications/beacon/AASSEVFK3EZ5HANONCX7MHDS2M3ZNA5CNFSM4WCQKUL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFVUSXHI.gif]
|
A configuration would be awesome for this! 🎉 In all clients (even Element), visiting the profile of a user displays this ugly-and-with-too-many-unecessary-underscores handle. Dropping the underscores would really make it more pleasant to the eye (and avoid bizarre line breaks on standard screen sizes, too) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
On Slack web interface - channel's and user's id looks good, like:
https://xxx.slack.com/client/T9SH61KC3/C9TFEAH9U
https://xxx.slack.com/client/T9SH61KC3/C9SH6NQ4B/user_profile/U9TFEAEDC
https://xxx.slack.com/team/U9TFEAEDC
But on Matrix side they contains too much underscores, here is example of
/client/T9SH61KC3/C9TFEAH9U
channel:and same - for puppeted users:
Slack seems using case-insensitive id of usernames, channels, threads, etc, and simply uppercase them in frontend. So we can boldly lowercase all Slack ids on mx-puppet-slack side before sending to mx-puppet-bridge, for make them looks more pretty on Matrix side, like:
For not broke old instances, we can make this optional, disabled by default.
What do you think about this idea?
The text was updated successfully, but these errors were encountered: