Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of versions ignores channel #229

Open
janiskemper opened this issue Jun 25, 2024 · 0 comments
Open

Validation of versions ignores channel #229

janiskemper opened this issue Jun 25, 2024 · 0 comments
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling

Comments

@janiskemper
Copy link
Member

/kind bug

What steps did you take and what happened:
We validate that the versions are correctly defined in our clusterstack webhook. However, we ignore the channel. We allow custom versions even if the channel is "stable". We have to make an additional check in our webhook that the channels of the versions match the channel specified in the clusterstack.

What did you expect to happen:
We have to validate for the stable channel that the channel of the versions is actually stable. For the custom channel we can allow anything that is a valid version and don't have to change anything.

We need to have tests that verify this and make sure it actually works as expected.

@janiskemper janiskemper added the Container Issues or pull requests relevant for Team 2: Container Infra and Tooling label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling
Projects
Status: Backlog
Development

No branches or pull requests

1 participant