-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace sub-command execution with proper code for Helm #33
Labels
Container
Issues or pull requests relevant for Team 2: Container Infra and Tooling
Comments
We followed the approach of ArgoCD (see e.g. https://github.com/argoproj/argo-cd/blob/820f4d861a7789f299143ed89816001091abf923/util/helm/cmd.go#L54). If there is an easier way, I'm open to other approaches! If you want to contribute, I can also support you on this. |
NotTheEvilOne
added a commit
that referenced
this issue
Dec 1, 2023
Closes: #33 Signed-off-by: Tobias Wolf <[email protected]>
NotTheEvilOne
added a commit
that referenced
this issue
Dec 1, 2023
Closes: #33 Signed-off-by: Tobias Wolf <[email protected]>
aniruddha2000
added a commit
that referenced
this issue
Feb 22, 2024
Add manual upgrade if no k8s version is changed Signed-off-by: Aniruddha Basak <[email protected]>
jschoone
added
the
Container
Issues or pull requests relevant for Team 2: Container Infra and Tooling
label
Feb 27, 2024
janiskemper
pushed a commit
that referenced
this issue
Jun 7, 2024
Add manual upgrade if no k8s version is changed Signed-off-by: Aniruddha Basak <[email protected]>
janiskemper
pushed a commit
that referenced
this issue
Jun 26, 2024
Add manual upgrade if no k8s version is changed Signed-off-by: Aniruddha Basak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewing the current operator I found
helmTemplate
which calls thehelm
executable to render the chart template.cluster-stack-operator/internal/controller/clusterstackrelease_controller.go
Line 312 in ad039ca
I would consider this function bad practice that needs replacement as soon as possible because of at least the following reasons:
There are at least two libraries (Helm [1] and go-helm-client [2]) that would just add the dependencies required to get the job done.
[1] https://github.com/helm/helm
[2] https://github.com/mittwald/go-helm-client
The text was updated successfully, but these errors were encountered: