I wonder if it will interfere with prospective pull requests if I add a .github actions job to do the unit testing code? #6
Closed
russelljjarvis
started this conversation in
Ideas
Replies: 2 comments
-
definitely prefer squashed commits. a github action to do CI is pretty standard, though i haven't gotten that fancy here. if you decide to code that up, put it in a separate PR as that is entirely unrelated to potjans. |
Beta Was this translation helpful? Give feedback.
0 replies
-
fixed by 974f679 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Will it interfere with prospective pull requests if I add a .github actions job to do the unit testing code?
I was thinking of recasting my connectome work as a unit test, .github actions unit test, but I also think this could step on toes, so I will hold back.
Also, do you prefer squashed commits for PR? I can try to squash everything into three commits.
Beta Was this translation helpful? Give feedback.
All reactions