Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brain Dumps: PhaseTracker Edition #705

Open
gabizou opened this issue Jun 17, 2018 · 3 comments
Open

Brain Dumps: PhaseTracker Edition #705

gabizou opened this issue Jun 17, 2018 · 3 comments
Labels
help wanted We would appreciate contributions input wanted We would like to hear your opinion
Milestone

Comments

@gabizou
Copy link
Member

gabizou commented Jun 17, 2018

So, since @Inscrutable asked for some more information on topics to document for the SpongeDocs, one of the priority topics is the PhaseTracker for the implementation in SpongeCommon/SpongeForge/SpongeVanilla.

So..... Without much to do:

PhaseTracker explained in a gist with Markdown:

https://gist.github.com/gabizou/e4d0e9e7fee420612c3519e14c450f16

@Inscrutable
Copy link
Member

Inscrutable commented Jun 18, 2018

I can probably start drafting that into something that looks more like our regular style, unless anyone else wants to volunteer. But so far (at a glance) it seems to consist largely of how it works, without much on how it can be used (or abused). It is critical to know what you're getting, so the nuts-and-bolts breakdown is useful, but there are probably many use-case needs that aren't yet satisfied. I welcome more opinions on this as I haven't any more than the foggiest idea myself.

@Inscrutable Inscrutable added help wanted We would appreciate contributions input wanted We would like to hear your opinion high priority This needs to be fixed ASAP labels Jun 18, 2018
@Inscrutable Inscrutable added this to the v7.X milestone Jun 18, 2018
@gabizou
Copy link
Member Author

gabizou commented Jun 18, 2018

Right, I haven't quite finished explaining how it's working, but I'm about to get to how it works once I explain about PhaseContexts.

@worm424 worm424 added the API not ready The API/code is not yet ready so we cannot merge this in yet label Aug 9, 2018
@Inscrutable
Copy link
Member

OK, Now I get that this section would primarily be aimed toward contributing to sponge, and not exposing it as an API. So this belongs under contributing/implementation.

@Inscrutable Inscrutable removed API not ready The API/code is not yet ready so we cannot merge this in yet high priority This needs to be fixed ASAP labels Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We would appreciate contributions input wanted We would like to hear your opinion
Projects
None yet
Development

No branches or pull requests

3 participants