Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why compute loss over torch.randn_like() rather than Gaussian noise multiplied with beta for each timestep? #405

Open
Foundsheep opened this issue Sep 27, 2024 · 0 comments

Comments

@Foundsheep
Copy link

Hi there, my question is simple.

def p_losses(self, x_start, t, noise=None):

On the link above, why the mse loss or whatever loss is computed over a pure Gaussian noise, which matches the noise of xT rather than a Gaussian noise multiplied with beta t at certain timestep?

I think mse, l1 or l2 loss should be done on the target and pred which are assumed to be the same.

Am I missing something or should it be modified?

Actually I can see the current logic works and a model is trained, but mathmatically I think my thought is right.

Also this could be found from huggingface's official tutorial
Screenshot 2024-09-26 104558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant