Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Metadata address option #1185

Open
rpmansion opened this issue Apr 16, 2020 · 1 comment
Open

Separate Metadata address option #1185

rpmansion opened this issue Apr 16, 2020 · 1 comment

Comments

@rpmansion
Copy link
Contributor

rpmansion commented Apr 16, 2020

Currently, we do not have a separate address path to view the metadata. Thus I have to define the ModulePath something like the below to do this which I know is being used as Saml2 base endpoints.

var spOptions = new SPOptions
{
       // . . .
	ModulePath = "saml2/sp/metadata",
        EntityId = new EntityId($"{baseUrl}/saml2/sp"),
};

The reason why I did this is some federations have the policy for naming the entity id like the UK Federation. However checking the metadata structure you would see the below parts.

<SingleLogoutService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect" Location="https://domain.com/saml2/sp/metadata/Logout" />
<AssertionConsumerService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" Location="https://domain.com/saml2/sp/metadata/Acs" index="0" isDefault="true" />
<AssertionConsumerService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Artifact" Location="domain.com/saml2/sp/metadata/Acs" index="1" isDefault="false" />

So if we could have another option to set the address for the metadata and instead of the browser downloading the file is to view this in the browser as XML?

@rpmansion rpmansion changed the title Separate Metadata address Separate Metadata address option Apr 16, 2020
@AndersAbel
Copy link
Member

Yes, better endpoint naming/routing would be good, see e.g. #1031 for a request to rename Acs.

What I think is important is to offer a configuration that by default makes people have the same Uri for EntityId and the metadata adress. It is recommended by the spec, but I know that there are many cases where that recommendation is not follwoed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants