-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow binary version to be configurable #3
Comments
Hi @weaverryan, I'd be happy to give a go at implementing this, (if satisfactory also for the tailwind bundle). Do you already have some idea on how you would like to do this? Would you like to have a list of supported versions and check beforehand? or merely failing with a 'you probably have a wrong version configured' message if the binary request in |
Yup, this :D. If you give us the version, we use that in the URL instead of https://github.com/SymfonyCasts/sass-bundle/blob/main/src/SassBinary.php#L19 and if it fails, it fails. So yes please! And on both bundles would be wonderful ❤️ |
There's a related PR for TailwindBundle: SymfonyCasts/tailwind-bundle#34 |
Currently, we hardcode the version of the binary that we download. Added this as a configuration option probably makes sense. (This is also true for https://github.com/SymfonyCasts/tailwind-bundle)
The text was updated successfully, but these errors were encountered: