Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Start]: $RefreshSig$ is not a function #2179

Open
omarkhatibco opened this issue Aug 23, 2024 · 3 comments
Open

[Start]: $RefreshSig$ is not a function #2179

omarkhatibco opened this issue Aug 23, 2024 · 3 comments
Labels
bug Something isn't working start Everything about TanStack Start

Comments

@omarkhatibco
Copy link

Describe the bug

This might not be a bug related to the start directly, but somehow it works fine in vite directly.

the problem that some file is not compliant with fast refresh and therefore it invalidates

it breaks in the start starter but works fine in vite.

check the repository for a reproduction

Your Example Website or App

https://github.com/omarkhatibco/start-test

Steps to Reproduce the Bug or Issue

run bun install and then bun dev
check both urls http://localhost:3000/ & http://localhost:5174/
you can see that start url is failing.

Expected behavior

it should work fine

Screenshots or Videos

No response

Platform

  • OS: macos
  • Browser: Chrome
  • Version: lastest

Additional context

No response

@SeanCassiere
Copy link
Member

Trying this out, I'm not getting any errors thrown in either "app" in the client or the server.

Following the reproduction steps, I ran the bun dev command and had both URLs opened. In each project, I made a change and observed the following.

  • In the vite project, on the client, an HMR update was performed with the updated content.
  • In the Start project, a page reload occurred with the updated content.

@tannerlinsley is this expected behaviour (given that this is SSR)?

@SeanCassiere SeanCassiere added information needed Further information is requested start Everything about TanStack Start labels Aug 29, 2024
@SeanCassiere
Copy link
Member

Speaking with Tanner, the HMR not replacing the modules and instead performing a full reload is indeed a bug.

@SeanCassiere SeanCassiere added bug Something isn't working and removed information needed Further information is requested labels Aug 29, 2024
@omarkhatibco
Copy link
Author

@SeanCassiere btw, I discovered that if you update something inside the monorepo library, the dev server will crash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working start Everything about TanStack Start
Projects
None yet
Development

No branches or pull requests

2 participants