Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(start): supply links() with same context signature as meta() #2427

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor(start): supply links() with same context signature as meta() #2427

wants to merge 3 commits into from
+53 −4

Conversation

SeanCassiere
Copy link
Member

Closes #2426

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 27, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c8939b7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 27, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2427

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2427

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2427

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2427

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2427

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2427

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2427

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2427

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2427

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2427

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2427

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2427

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2427

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2427

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2427

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2427

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2427

commit: c8939b7

SeanCassiere
SeanCassiere commented Sep 27, 2024
View reviewed changes
Copy link
Member Author

@SeanCassiere SeanCassiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things open for discussion:

  1. whether we want to replicate this behaviour for scripts.
  2. whether we want to include matches and match in the function's context like we do for meta.

@SeanCassiere SeanCassiere changed the title fix(start): supply links() with loaderData and params refactor(start): supply links() with loaderData and params Sep 27, 2024
@SeanCassiere SeanCassiere marked this pull request as ready for review September 27, 2024 05:47
@SeanCassiere SeanCassiere changed the title refactor(start): supply links() with loaderData and params refactor(start): supply links() with same context signature as meta() Sep 27, 2024
@lo1tuma
Copy link
Contributor

lo1tuma commented Sep 30, 2024

For scripts() I would appreciate to get the same information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@SeanCassiere @lo1tuma