Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: update_readme script fails when there's no Deposit Agreement #244

Open
astrochun opened this issue Jul 27, 2021 · 0 comments
Open

Bug: update_readme script fails when there's no Deposit Agreement #244

astrochun opened this issue Jul 27, 2021 · 0 comments
Labels
bug Something isn't working p1 Issues affecting production, multiple users
Milestone

Comments

@astrochun
Copy link
Contributor

Describe the bug

A couple of weeks ago I was doing some testing of the scripts and noticed an issue. The update_readme script failed. This was a stage deposit that didn't have a Deposit Agreement form. For reference, the Deposit Agreement is gather for the Corresponding Author metadata. This is done in the early stages to populate dict's for the README input. This is very much an edge case situation as most deposits will have a Deposit Agreement. This issue is mostly as a reminder. I'll try to find the old error message or recreate it.

Reproduction Steps

I'll see if I can find it, but it involves running update_readme with a deposit that does not have a Deposit Agreement

Outputted Messages

I'll see if I can recreate the error message/track back.

Version information

  • LD_Cool-P version: [e.g. 0.17.0]

Expected behavior

In such a case, it should warn that a Deposit Agreement is not available and either:

  1. Exit gracefully, or
  2. Ask whether to proceed with NaN filled in.

Screenshots

Additional context

Implemented in: TBD

@astrochun astrochun added bug Something isn't working p1 Issues affecting production, multiple users labels Jul 27, 2021
@astrochun astrochun added this to the v1.2.0 milestone Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1 Issues affecting production, multiple users
Projects
None yet
Development

No branches or pull requests

1 participant