Fix: Preprocessing of articles stops if curation folder does not exist for an article (Issue #105) #107
+108
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
zoidy
requested changes
Oct 1, 2024
zoidy
approved these changes
Oct 3, 2024
zoidy
deleted the
105-bug-preprocessing-of-articles-stops-if-curation-folder-does-not-exist-for-an-article
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While fetching items, preservation remote storages are checked for a preserved copy of each item. For an article, the size (in bytes) of its UAL_RDM folder in curation storage is required (#103). If the UAL_RDM folder of an article is not found or an error occurs during size calculation, the fetching of articles stops regardless of whether there are more articles to be fetched.
This PR fixes the issue by logging an error and aborting execution if the --continue-on-error flag is not set else it logs an error and skips the article with with error. It also updates the execution notes in README with this behaviour.
Note: This PR adds counts of articles and versions with fetch error the to log summary.
Fixes #105
Screenshots or additional context
None
Testing (if applicable)
See Steps To Reproduce in #105