Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update redata-commons dependency #56

Open
1 of 2 tasks
zoidy opened this issue Aug 4, 2023 · 0 comments
Open
1 of 2 tasks

Chore: update redata-commons dependency #56

zoidy opened this issue Aug 4, 2023 · 0 comments
Labels
chore good first issue Good for newcomers

Comments

@zoidy
Copy link
Collaborator

zoidy commented Aug 4, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Description

Update redata in requirements.txt to 0.51. This release updates the requests and urllib3 libraries with possible breaking changes.

  • requests 2.29 introduces a change to how chunked downloads are handled
  • requests 2.30 introduces urllib3 2.0 which itself may have breaking changes

Suggested Implementation

ReBACH uses chunked downloads. Therefore, the following tests are needed.

  • test downloading large files (anything more than a few tens of MB)
@zoidy zoidy added good first issue Good for newcomers chore labels Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant