Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pcode endpoint #1

Open
sblack-usu opened this issue Feb 7, 2020 · 0 comments
Open

Fix pcode endpoint #1

sblack-usu opened this issue Feb 7, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@sblack-usu
Copy link
Collaborator

The pcode endpoint does not work because the tool provides query parameters as a dictionary, which reduces the multiple "show" key query parameters to only the last one provided. See code here

https://github.com/UCHIC/dataretrieval/blob/master/dataretrieval/nwis.py#L367

This will also have to be fixed in the query method here

def query(url, **kwargs):

Modifying the query function may have a cascading effect causing a lot of refactoring... I think it's worth exploring, but considering there are few tests, we may want to establish tests around the library before doing such work.

Acceptance Criteria:

  • Fix the pmcode method to use a list of tuples for the query params,
  • Either refactor the query method to support list of tuples or create a new issue describing the work necessary.
@sblack-usu sblack-usu added the bug Something isn't working label Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant