Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed everything related to menuBar and floating line #327

Merged
merged 6 commits into from
Jun 25, 2023

Conversation

Varghab
Copy link
Contributor

@Varghab Varghab commented Jun 24, 2023

Related Issue

  • Information about the related issue

Closes: #326

Describe the changes you've made

The Menubar I created previously (currently used on the website) is not working properly. Here, is the updated menu bar I created that fixes all the issues. Sorry for any inconvenience caused.

The problem with the current Menubar used in the website -

  • Disabled clicking any button or links on the home page.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Screenshot 2023-06-24 053403
Screenshot 2023-06-24 053417

Code of Conduct

@vercel
Copy link

vercel bot commented Jun 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vibey ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 4:21pm

@vercel
Copy link

vercel bot commented Jun 24, 2023

@Varghab is attempting to deploy a commit to the unikonf-vibey Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating a pull request for vibey!

We appreciate your contribution and are excited to review your changes. If you have any questions or need additional information, please don't hesitate to let us know. We look forward to working with you to improve vibey. Thanks again for your support!

If you want to keep contributing to open source and want to do it with a supportive and inclusive community, consider joining UniKonf. We help and encourage each other to make regular contributions to open source projects. If you have any questions, do not hesitate to ask. We look forward to having you as part of our community!

Copy link
Collaborator

@Deepu178 Deepu178 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Varghab for making the contribution to the project and looking forward for more contribution from your side.

@Varghab
Copy link
Contributor Author

Varghab commented Jun 25, 2023

@Deepu178 Hey, the changes are not yet reflected, is there anything I should do from my side?

@Varghab Varghab requested a review from Deepu178 June 25, 2023 16:08
@Deepu178 Deepu178 merged commit 7dfcc15 into UniKonf:main Jun 25, 2023
3 checks passed
@Deepu178 Deepu178 added gssoc23 This label aids in the tracking of issues for octabot used by GSSoC'23 for tracking. level2 Level describing the difficulty nature of the raised issue labels Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 This label aids in the tracking of issues for octabot used by GSSoC'23 for tracking. level2 Level describing the difficulty nature of the raised issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Line floating on the screen
2 participants