You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 9, 2020. It is now read-only.
We're trying to integrate this library with Google SignIn, and however subscriber gets no result.
After investigation, we found that there's potential issue for this library. For Google SignIn, they use a SignInHubActivity, which presents a dialog then puts itself into pause state. Then when user click on the dialog option, it will set result and finish activity.
I have another case but which is very similar.
I get OnResult.response right in the middle of onActivityPaused for target activity and onActivityResumed of starter activity.
so, OnResult.response is ignored and never processed again
We're trying to integrate this library with Google SignIn, and however subscriber gets no result.
After investigation, we found that there's potential issue for this library. For Google SignIn, they use a
SignInHubActivity
, which presents a dialog then puts itself into pause state. Then when user click on the dialog option, it will set result and finish activity.RxActivityResult/rx_activity_result/src/main/java/rx_activity_result2/ActivitiesLifecycleCallbacks.java
Lines 37 to 39 in 721d059
At this moment,
RxActivityResult.activitiesLifecycle.getLiveActivity()
returnsnull
and thus breaks the expected subscription behavior.Possibly related: #36
Possible fix: use
getOLiveActivity
insteadThe text was updated successfully, but these errors were encountered: