Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network speed difference shouldn't affect score #329

Open
rniwa opened this issue Oct 25, 2023 · 3 comments
Open

Network speed difference shouldn't affect score #329

rniwa opened this issue Oct 25, 2023 · 3 comments
Assignees
@camillobruni
Labels
non-trivial change A change that affects benchmark results v4

Comments

@rniwa
Copy link
Member

rniwa commented Oct 25, 2023

See https://webkit.slack.com/archives/C05QJJZQZRQ/p1698264053662939.

Apparently the network speed difference can affect Speedometer 2.0 score.
We should make sure to either verify that this doesn't happen on Speedometer 3.0 or mitigate it some way e.g. prime network cache prior to start measurements.
@rniwa rniwa added non-trivial change A change that affects benchmark results v3-blocker labels Oct 25, 2023
@camillobruni camillobruni self-assigned this Nov 1, 2023
@rniwa
Copy link
Member Author

rniwa commented Nov 15, 2023

The consensus here seems to be investigating adding HTTP header for caching so that browsers would consistently cache or not cache.

@bgrins bgrins removed the v3-blocker label Nov 15, 2023
@rniwa rniwa added the v3.1 label Feb 24, 2024
@rniwa
Copy link
Member Author

rniwa commented Feb 24, 2024

I'd say this is out of v3 at this point. Perhaps v3.1?

@camillobruni
Copy link
Contributor

Yeah, sounds good to look into this in a later version.
v3.0 is not worse than v2.1 in that respect, so technically not a regression.

@rniwa rniwa added v4 and removed v3.1 labels Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camillobruni camillobruni

Labels
non-trivial change A change that affects benchmark results v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bgrins @camillobruni @rniwa