Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using "Chinese (language name, script/variant name)" as the main name for languages under Sinitic language group #1410

Closed
winstonsung opened this issue Aug 8, 2024 · 5 comments · Fixed by #1427
Labels
enhancement Adding or requesting a new feature.

Comments

@winstonsung
Copy link
Contributor

winstonsung commented Aug 8, 2024

Describe the problem

Currently, most languages under Sinitic language group are having "Chinese (language name, script/variant name)"-style names.

However, this would be confusing as:

  • We mostly only use "Chinese" to refer "Mandarin"/"Cantonese".
  • Only writing "Simplified" does not indicate the difference is based on script (writing system).

For example, gan "Gan" (preferred solution) / "Gan Chinese" (alternative solution) / "Chinese (Gan)" (confusing option)

Describe the solution you would like

  • cdo-Hans "Mindong (Simplified Han script)"
  • cdo-Hant "Mindong (Traditional Han script)"
  • cdo-Latn "Mindong (Latin script)"
  • cpx-Hans "Pu–Xian Min (Simplified Han script)"
  • cpx-Hant "Pu–Xian Min (Traditional Han script)"
  • cpx-Latn "Pu–Xian Min (Latin script)"
  • gan-Hans "Gan (Simplified Han script)"
  • gan-Hant "Gan (Traditional Han script)"
  • hak-Hans "Hakka (Simplified Han script)"
  • hak-Hant "Hakka (Traditional Han script)"
  • hak-Latn "Hakka (Latin script)"
  • hsn "Xiang"
  • lzh "Literary Chinese"
  • nan-Hant "Hokkien (Traditional Han script)"
  • nan-Latn-pehoeji "Hokkien (Pe̍h-ōe-jī)"
  • nan-Latn-tailo "Hokkien (Tâi-lô)"
  • wuu-Hans "Wu (Simplified Han script)"
  • wuu-Hant "Wu (Traditional Han script)"
  • yue-Hans "Cantonese (Simplified Han script)"
  • yue-Hant "Cantonese (Traditional Han script)"
  • zh-Hans "Chinese (Traditional Han script)"
  • zh-Hans-SG "Chinese (Traditional Han script, Singapore)"
  • zh-Hant "Chinese (Traditional Han script)"
  • zh-Hant-HK "Chinese (Traditional Han script, Hong Kong)"
  • zh-Latn-CN "Chinese (Hanyu Pinyin, Mainland China)"
  • zh-Latn-TW-pinyin "Chinese (Hanyu Pinyin, Taiwan)"
  • zh-Latn-TW-tongyong "Chinese (Tongyong Pinyin, Taiwan)"
  • zh-Latn-TW-wadegile "Chinese (Wade–Giles, Taiwan)"

Describe alternatives you have considered

  • cdo-Hans "Mindong (Simplified Han)"
  • cdo-Hant "Mindong (Traditional Han)"
  • cdo-Latn "Mindong (Latin)"
  • cpx-Hans "Pu–Xian Min (Simplified Han)"
  • cpx-Hant "Pu–Xian Min (Traditional Han)"
  • cpx-Latn "Pu–Xian Min (Latin)"
  • gan-Hans "Gan (Simplified Han)"
  • gan-Hant "Gan (Traditional Han)"
  • hak-Hans "Hakka (Simplified Han)"
  • hak-Hant "Hakka (Traditional Han)"
  • hak-Latn "Hakka (Latin)"
  • hsn "Xiang"
  • lzh "Literary Chinese"
  • nan-Hant "Hokkien (Traditional Han)"
  • nan-Latn-pehoeji "Hokkien (Pe̍h-ōe-jī)"
  • nan-Latn-tailo "Hokkien (Tâi-lô)"
  • wuu-Hans "Wu (Simplified Han)"
  • wuu-Hant "Wu (Traditional Han)"
  • yue-Hans "Cantonese (Simplified Han)"
  • yue-Hant "Cantonese (Traditional Han)"
  • zh-Hans "Chinese (Traditional Han)"
  • zh-Hans-SG "Chinese (Traditional Han, Singapore)"
  • zh-Hant "Chinese (Traditional Han)"
  • zh-Hant-HK "Chinese (Traditional Han, Hong Kong)"
  • zh-Latn-CN "Chinese (Hanyu Pinyin, Mainland China)"
  • zh-Latn-TW-pinyin "Chinese (Hanyu Pinyin, Taiwan)"
  • zh-Latn-TW-tongyong "Chinese (Tongyong Pinyin, Taiwan)"
  • zh-Latn-TW-wadegile "Chinese (Wade–Giles, Taiwan)"

Screenshots

No response

Additional context

No response

@winstonsung
Copy link
Contributor Author

(push)

@nijel
Copy link
Member

nijel commented Aug 23, 2024

Pull requests are welcome! Master language definitions are at https://github.com/WeblateOrg/language-data/blob/main/languages.csv

@nijel nijel added the enhancement Adding or requesting a new feature. label Aug 23, 2024
winstonsung added a commit to winstonsung/weblate-language-data that referenced this issue Aug 23, 2024
closes WeblateOrg#1410
closes WeblateOrg#1411

Bug: WeblateOrg#1410
Bug: WeblateOrg#1411
Change-Id: Ibc4e7802d6a331511792da37824378074722c5c0
winstonsung added a commit to winstonsung/weblate-language-data that referenced this issue Aug 23, 2024
closes WeblateOrg#1410
closes WeblateOrg#1411

Bug: WeblateOrg#1410
Bug: WeblateOrg#1411
Change-Id: Ibc4e7802d6a331511792da37824378074722c5c0
winstonsung added a commit to winstonsung/weblate-language-data that referenced this issue Aug 23, 2024
closes WeblateOrg#1410
closes WeblateOrg#1411

Bug: WeblateOrg#1410
Bug: WeblateOrg#1411
Change-Id: Ibc4e7802d6a331511792da37824378074722c5c0
winstonsung added a commit to winstonsung/weblate-language-data that referenced this issue Aug 24, 2024
closes WeblateOrg#1410
closes WeblateOrg#1411

Bug: WeblateOrg#1410
Bug: WeblateOrg#1411
Change-Id: Ibc4e7802d6a331511792da37824378074722c5c0
winstonsung added a commit to winstonsung/weblate-language-data that referenced this issue Aug 24, 2024
closes WeblateOrg#1410
closes WeblateOrg#1411

Bug: WeblateOrg#1410
Bug: WeblateOrg#1411
Change-Id: Ibc4e7802d6a331511792da37824378074722c5c0
winstonsung added a commit to winstonsung/weblate-language-data that referenced this issue Aug 24, 2024
closes WeblateOrg#1410
closes WeblateOrg#1411

Bug: WeblateOrg#1410
Bug: WeblateOrg#1411
Change-Id: Ibc4e7802d6a331511792da37824378074722c5c0
winstonsung added a commit to winstonsung/weblate-language-data that referenced this issue Aug 24, 2024
closes WeblateOrg#1410
closes WeblateOrg#1411

Bug: WeblateOrg#1410
Bug: WeblateOrg#1411
Change-Id: Ibc4e7802d6a331511792da37824378074722c5c0
winstonsung added a commit to winstonsung/weblate-language-data that referenced this issue Aug 24, 2024
closes WeblateOrg#1410
closes WeblateOrg#1411

Bug: WeblateOrg#1410
Bug: WeblateOrg#1411
Change-Id: Ibc4e7802d6a331511792da37824378074722c5c0
winstonsung added a commit to winstonsung/weblate-language-data that referenced this issue Aug 24, 2024
closes WeblateOrg#1410
closes WeblateOrg#1411

Bug: WeblateOrg#1410
Bug: WeblateOrg#1411
Change-Id: Ibc4e7802d6a331511792da37824378074722c5c0
winstonsung added a commit to winstonsung/weblate-language-data that referenced this issue Aug 24, 2024
closes WeblateOrg#1410
closes WeblateOrg#1411

Bug: WeblateOrg#1410
Bug: WeblateOrg#1411
Change-Id: Ibc4e7802d6a331511792da37824378074722c5c0
winstonsung added a commit to winstonsung/weblate-language-data that referenced this issue Aug 24, 2024
closes WeblateOrg#1410
closes WeblateOrg#1411

Bug: WeblateOrg#1410
Bug: WeblateOrg#1411
Change-Id: Ibc4e7802d6a331511792da37824378074722c5c0
winstonsung added a commit to winstonsung/weblate-language-data that referenced this issue Aug 24, 2024
closes WeblateOrg#1410
closes WeblateOrg#1411

Bug: WeblateOrg#1410
Bug: WeblateOrg#1411
Change-Id: Ibc4e7802d6a331511792da37824378074722c5c0
winstonsung added a commit to winstonsung/weblate-language-data that referenced this issue Aug 24, 2024
- Use "language name (script/orthography name)" instead of "Chinese (language name, script/orthography name)"
- Add Sinitic languages
- Add Formosan languages (Taiwanese aboriginal languages)
- Split gan into gan-Hans, gan-Hant
- Split hak into hak-Hans, hak-Hant, hak-Latn

closes WeblateOrg#1410
closes WeblateOrg#1411

Bug: WeblateOrg#1410
Bug: WeblateOrg#1411
Change-Id: Ibc4e7802d6a331511792da37824378074722c5c0
@winstonsung
Copy link
Contributor Author

@nijel wrote:
Pull requests are welcome! Master language definitions are at https://github.com/WeblateOrg/language-data/blob/main/languages.csv

Thanks. However, not all

weblate_language_data\locale\*\LC_MESSAGES\django.po

files were updated when using

make

(especially for those language tag with underscores), any ideas about the issue (or is it intended)?

Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

1 similar comment
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants