Multi PHP + Multi Environment + Check all commits #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
- add the label - test dir is a dir (a tmp one) - no cert validation by default - simple WP by default
- support for labels - read latest commits
|
The code is not very beauty, but it should work... |
javiercasares
changed the title
This was
linked to
issues
Mar 17, 2024
this is a first step to include some documentation inside the project, and not only in the handbook page.
pfefferle
reviewed
Jun 13, 2024
prepare.php
Outdated
| @@ -164,6 +276,7 @@ | |||
| \$imagick_info = Imagick::queryFormats(); | |||
| } | |||
| \$env = array( | |||
| 'label' => '{$WPT_LABEL}', | |||
There was a problem hiding this comment.
there seems to be something broken with the indents?!
This was referenced Sep 25, 2024
Co-authored-by: Matthias Pfefferle <[email protected]>
Co-authored-by: Matthias Pfefferle <[email protected]>
Co-authored-by: Matthias Pfefferle <[email protected]>
Co-authored-by: Matthias Pfefferle <[email protected]>
Co-authored-by: Matthias Pfefferle <[email protected]>
Co-authored-by: Matthias Pfefferle <[email protected]>
Co-authored-by: Matthias Pfefferle <[email protected]>
- Descriptions in 80 chars columns - Some Yoda fixes - Fix the "tab" vs "space" - Check some "comments" that should not be there (they were because some errors on the developing era)
- Better comments / PHPDoc - Improved code quality (do the same, in a better way) - reduce duplicated code (that's something we didn't care at Cloudfest) - updated the Runner Compatibity with PHP 7.2 (as WordPress is)
- Improved readability - default .env updated from source - other fixes
- better documentation - details on each value at the configuration file - scripts so you can run (and update) the software automatically.
|
I applied the suggestion @pfefferle did on WordCamp Europe, and reduce a lot of duplicated code that we couldn't do at the Cloudfest Hackathon, mostly on the parts when testing multiple PHP versions. I did some improvements on the documentation, with some scripts so the software (from the main branch) is updated and maintained automatically. I've been doing some tests in my local machine, and on my production server (where I was doing the former tests) and looks like everything is working. On my side, I think everything is in order, and we can approve this and put it available for everyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Cloudfest Hackathon 2024 PR.
This PR solves:
The test-reporter will be upgraded to comply with these changes.