Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify search fields #384

Open
jasmussen opened this issue Sep 30, 2024 · 5 comments
Open

Unify search fields #384

jasmussen opened this issue Sep 30, 2024 · 5 comments
Assignees

Comments

@jasmussen
Copy link

Ideally all 1-line input fields are 40px tall. This search on make/core is 38:

Image

The one from make/design looks different:

Image

Ideally they can be the same.

@adamwoodnz adamwoodnz transferred this issue from WordPress/wporg-make Sep 30, 2024
@adamwoodnz
Copy link

This difference is caused by some blogs using legacy search widgets and some using blocks. Meta for example is using the Search block with the settings to match the other sites, and the Jetpack subscription block with the smaller button:

Image

I was thinking we would update all the sites to use these, look ok to you?

From my testing, functionally they are the same.

@adamwoodnz adamwoodnz moved this from 📋 To do to 🛑 Pending discussion in WordPress.org Redesign Oct 4, 2024
@jasmussen
Copy link
Author

I was thinking we would update all the sites to use these, look ok to you?

Sounds good to me.

@adamwoodnz adamwoodnz self-assigned this Oct 16, 2024
@adamwoodnz
Copy link

adamwoodnz commented Oct 16, 2024

Sites updated

  • core
  • design
  • mobile
  • accessibility
  • polyglots
  • support
  • docs
  • themes
  • plugins
  • community
  • meta
  • training
  • test
  • tv
  • marketing
  • cli
  • hosting
  • tide
  • openverse
  • photos
  • performance
  • sustainability
  • media-corps
  • systems
  • project
  • updates

@adamwoodnz
Copy link

Note that the mobile site uses the legacy Jetpack search widget, so the search block is not a direct replacement, and it hasn't been updated. The subscription form has though.

bazza pushed a commit that referenced this issue Oct 17, 2024
@adamwoodnz
Copy link

adamwoodnz commented Oct 17, 2024

We can't change the handbook search fields to blocks until after launch, as there are functional changes required (modifying the form action), but I've added a task to do this afterward. For now only Meta has custom CSS to switch visibility of the legacy and block fields for testing purposes.

bazza pushed a commit that referenced this issue Oct 17, 2024
bazza pushed a commit that referenced this issue Oct 17, 2024
Reverts previous commit which hides them.

See #384


git-svn-id: https://meta.svn.wordpress.org/sites/trunk@14121 74240141-8908-4e6f-9713-ba540dce6ec7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: On Hold/Blocked
Development

No branches or pull requests

2 participants