-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify search fields #384
Comments
This difference is caused by some blogs using legacy search widgets and some using blocks. Meta for example is using the Search block with the settings to match the other sites, and the Jetpack subscription block with the smaller button: I was thinking we would update all the sites to use these, look ok to you? From my testing, functionally they are the same. |
Sounds good to me. |
Sites updated
|
Note that the mobile site uses the legacy Jetpack search widget, so the search block is not a direct replacement, and it hasn't been updated. The subscription form has though. |
See #384 git-svn-id: https://meta.svn.wordpress.org/sites/trunk@14116 74240141-8908-4e6f-9713-ba540dce6ec7
We can't change the handbook search fields to blocks until after launch, as there are functional changes required (modifying the form action), but I've added a task to do this afterward. For now only Meta has custom CSS to switch visibility of the legacy and block fields for testing purposes. |
See #384 git-svn-id: https://meta.svn.wordpress.org/sites/trunk@14120 74240141-8908-4e6f-9713-ba540dce6ec7
Reverts previous commit which hides them. See #384 git-svn-id: https://meta.svn.wordpress.org/sites/trunk@14121 74240141-8908-4e6f-9713-ba540dce6ec7
Ideally all 1-line input fields are 40px tall. This search on make/core is 38:
The one from make/design looks different:
Ideally they can be the same.
The text was updated successfully, but these errors were encountered: