Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check_libxrpl CI flow #1582

Closed
godexsoft opened this issue Aug 6, 2024 · 0 comments · Fixed by #1583
Closed

Fix check_libxrpl CI flow #1582

godexsoft opened this issue Aug 6, 2024 · 0 comments · Fixed by #1583
Assignees
@godexsoft
Labels
bug Something isn't working ci CI related issues

Comments

@godexsoft
Copy link
Collaborator

Issue Description

XRPLF/rippled#5028 uses Conan channels in order to store libxrpl packages that need to be verified by check_libxrpl flow. Everything goes well until we try to upload the artifact of clio_tests with a name containing a forward slash. See https://github.com/godexsoft/clio/actions/runs/10270363766/job/28417911420 for example.

Steps to Reproduce

Notify check_libxrpl of a new package with channel syntax (xrpl/version@clio/pr_num) to test.

Expected Result

Workflow should be able to upload and download the artifact.

Actual Result

Artifact upload fails due to forward slash.
@godexsoft godexsoft added bug Something isn't working ci CI related issues labels Aug 6, 2024
@godexsoft godexsoft self-assigned this Aug 6, 2024
@godexsoft godexsoft mentioned this issue Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@godexsoft godexsoft

Labels
bug Something isn't working ci CI related issues
Projects
Clio
Status: ✅ Merged
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Support conan channels in check_libxrpl flow godexsoft/clio
1 participant
@godexsoft