Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

card is not swiping on button click #464

Open
sahabe1 opened this issue Jan 3, 2021 · 5 comments
Open

card is not swiping on button click #464

sahabe1 opened this issue Jan 3, 2021 · 5 comments

Comments

@sahabe1
Copy link

sahabe1 commented Jan 3, 2021

swipe left and swipe right not working on button click
same issue is happening in demo code

@timothyerwin
Copy link

I am seeing the same issue

@timothyerwin
Copy link

This seems to be happening if you call .swipe() too quickly...but then it's unusable as the swipe must be delayed to a certain time limit....please fix it

@timothyerwin
Copy link

This is caused because isAnimating is true even after the card is already swiped thus blocking fast swipes

@aliabbas90
Copy link

I am not facing this issue while I am dragging cards but while the button is tapped. After an investigation in the source code, I found that the increment method (in KolodaAnimationSemaphore) is called twice when we call the swipe method (for eg. kolodaView.swipe(.right)). I was able to fix the issue by removing the animationSemaphore.increment() from public func swipe(_ direction: SwipeResultDirection, force: Bool = false) in KolodaView.swift file. It will be incremented in the swipedAction from KolodaView.swift, so removing this line will avoid the double incrementation.

@harshvirsinh
Copy link

not wor

I am not facing this issue while I am dragging cards but while the button is tapped. After an investigation in the source code, I found that the increment method (in KolodaAnimationSemaphore) is called twice when we call the swipe method (for eg. kolodaView.swipe(.right)). I was able to fix the issue by removing the animationSemaphore.increment() from public func swipe(_ direction: SwipeResultDirection, force: Bool = false) in KolodaView.swift file. It will be incremented in the swipedAction from KolodaView.swift, so removing this line will avoid the double incrementation.

not working bro..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants