Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Install script does not take system architecture into account #1065

Open
mortiet opened this issue May 15, 2022 · 2 comments
Open

Install script does not take system architecture into account #1065

mortiet opened this issue May 15, 2022 · 2 comments
Labels
🔨 improvement Improvement in features 🐧 Linux This issue or pull request is specific to the Linux operating system

Comments

@mortiet
Copy link

mortiet commented May 15, 2022

What happened:
Installed ritchicli on armbian x64 and the install script didn't even notice that I'm on arm-based linux

What you expected to happen:
Either the install script should inform the user that this architecture is not supported or you can provide binaries for different architectures

How to reproduce it (as minimally and precisely as possible):
Try installing ritchicli on different linux architectures

Environment:

  • Ritchie version (use rit --version): 2.11.3
  • Operating System: Armbian x64
  • Network plugin / Tool and version (if this is a network-related / tool bug):
  • Others:
@GuillaumeFalourd
Copy link
Contributor

Hi @mortiet! Thank you for opening this issue.

According to the documentation, Ritchie CLI currently has support for RPM, DEBIAN and ARCH LINUX.

The installation script (using curl -fsSL https://commons-repo.ritchiecli.io/install.sh | bash) doesn't check the linux version indeed, and Ritchie may not have support for Armbian x64.

Would you have any suggestion regarding how to create a package for this distribution using the linux binary?

@GuillaumeFalourd GuillaumeFalourd added 🔨 improvement Improvement in features 🐧 Linux This issue or pull request is specific to the Linux operating system labels May 16, 2022
@mortiet
Copy link
Author

mortiet commented May 16, 2022

@GuillaumeFalourd You can cross-compile with golang for different architectures:

env GOOS=linux GOARCH=arm64 go build -o rit

And in the install.sh, this command shows the architecture $(uname -m)

  • "x86_64" --> Currently supported architecture
  • "aarch64" or "arm64" --> Arm64 architecture

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔨 improvement Improvement in features 🐧 Linux This issue or pull request is specific to the Linux operating system
Projects
None yet
Development

No branches or pull requests

2 participants