Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filterBy on boolean is not working #208

Open
Badisi opened this issue Jun 27, 2016 · 1 comment
Open

filterBy on boolean is not working #208

Badisi opened this issue Jun 27, 2016 · 1 comment

Comments

@Badisi
Copy link

Badisi commented Jun 27, 2016

Filtering on a boolean property has no effect at all.
Example: $filter('filterBy')(collection, ['property'], true)

Looking at the source we can see that only string and number are allowed.
Line 14: search = (isString(search) || isNumber(search)) ? String(search).toLowerCase() : undefined;

@Badisi Badisi changed the title filterBy with boolean is not working filterBy on boolean is not working Jun 27, 2016
@vmironovs
Copy link

yes, it will be great to have it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants