Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KiB and MiB are wrongly used in place of kB and MB #254

Open
evilaliv3 opened this issue Aug 10, 2017 · 2 comments
Open

KiB and MiB are wrongly used in place of kB and MB #254

evilaliv3 opened this issue Aug 10, 2017 · 2 comments

Comments

@evilaliv3
Copy link

The current implementation for byteFmt and kbFmt is using KiB(kibibyte) and MiB (mebibyte) are wrongly used in place of kB(kilobyte) and MB (megabyte).

The issue should be fixed in compatibility with the most common convension of softwares like the linux filesystem, chrome, firefox.

Evidences of the issue are present on the following ticket: globaleaks/globaleaks-whistleblowing-software#2044

A diffuse explaination is present on the wikipedia page: https://en.wikipedia.org/wiki/Kilobyte

image

@evilaliv3
Copy link
Author

evilaliv3 commented Aug 12, 2017

In the real only linux and mac use the correct Kb definitions while Microsoft still use the 1024 size so that it is not possible to obtain something completely "correct".

@nmoinvaz
Copy link

It might be better to modify the filters to take a second parameter which is the base 10 or 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants