Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flakey tests #916

Closed
wants to merge 3 commits into from
Closed

Flakey tests #916

wants to merge 3 commits into from

Conversation

AndyTWF
Copy link
Contributor

@AndyTWF AndyTWF commented Feb 7, 2023

Adds some fixes for some flakey tests.

Fixes #898

In theory, the channel state could arrive to the state listener
before the arrays of channel states updated, causing a flakey test.

This fixes that.
Some test runners were picking it up as a test in its own right,
which was then causing JUnit ti complain as it contains no test
case methods.

By making it abstract, it allows us to extend it for protocol testing
but not make it runnable in its own right.
State transitions could happen very quickly, meaning that channel.state
may have proceeded at the point we assert the channel has attached etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Flakey Realtime test attach_when_channel_in_detaching_state in RealtimeChannelTest
1 participant