Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Please update action.yml to use Node16 #222

Open
richb-hanover opened this issue Nov 23, 2022 · 3 comments
Open

Please update action.yml to use Node16 #222

richb-hanover opened this issue Nov 23, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@richb-hanover
Copy link

Do the checklist before filing an issue:

Description

In my project, I'm seeing deprecation warnings about Node12. They look like:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: jetli/[email protected], actions-rs/cargo@v1

Could you update the action.yml file to use node16 as described in https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions

Thanks!

Workflow code

See above

Action output

See above

Expected behavior

No node12 warnings

Additional context

Add any other context about the problem here.

@richb-hanover richb-hanover added the bug Something isn't working label Nov 23, 2022
@cryptoquick
Copy link

Is this project still maintained? It's been over a month since this was open, and there's two PRs open for it: #217 #223

If not, what's the plan? Has one been discussed anywhere?

@parasyte
Copy link

actions-rs is unmaintained. See discussion in actions-rs/toolchain#216 There are comments with suggestions for alternatives.

mizar added a commit to mizar/ac-library-rs that referenced this issue Mar 26, 2023
* `actions/checkout@v3`
* `actions/setup-python@v4`
* `actions-rs` is unmaintained:
  * actions-rs/toolchain#219
  * actions-rs/cargo#222
* Library Checker: Rust 1.60
  * https://judge.yosupo.jp/help
mizar added a commit to mizar/ac-library-rs that referenced this issue Mar 26, 2023
* `actions/checkout@v3`
* `actions/setup-python@v4`
* `actions-rs` is unmaintained:
  * actions-rs/toolchain#219
  * actions-rs/cargo#222
* Library Checker: Rust 1.60
  * https://judge.yosupo.jp/help
mizar added a commit to mizar/ac-library-rs that referenced this issue Mar 26, 2023
* `actions/checkout@v3`
* `actions/setup-python@v4`
* `actions-rs` is unmaintained:
  * actions-rs/toolchain#219
  * actions-rs/cargo#222
* Library Checker: Rust 1.60
  * https://judge.yosupo.jp/help
mizar added a commit to mizar/ac-library-rs that referenced this issue Mar 26, 2023
* `actions/checkout@v3`
* `actions/setup-python@v4`
* `actions-rs` is unmaintained:
  * actions-rs/toolchain#219
  * actions-rs/cargo#222
* Library Checker: Rust 1.60
  * https://judge.yosupo.jp/help
mizar added a commit to mizar/ac-library-rs that referenced this issue Mar 26, 2023
* `actions/checkout@v3`
* `actions/setup-python@v4`
* `actions-rs` is unmaintained:
  * actions-rs/toolchain#219
  * actions-rs/cargo#222
* Library Checker: Rust 1.60
  * https://judge.yosupo.jp/help
mizar added a commit to rust-lang-ja/ac-library-rs that referenced this issue Mar 26, 2023
* ci.yml to use Node16

* `actions/checkout@v3`
* `actions/setup-python@v4`
* `actions-rs` is unmaintained:
  * actions-rs/toolchain#219
  * actions-rs/cargo#222
* Library Checker: Rust 1.60
  * https://judge.yosupo.jp/help

* clippy allow renamed-and-removed-lints
  * https://doc.rust-lang.org/rustc/lints/listing/warn-by-default.html#renamed-and-removed-lints

* `cargo`, `rustup` execute from `$PATH`

* uses dtolnay/rust-toolchain@master
@clechasseur
Copy link

In case anyone's interested, I forked this Action and published a working version that uses node16: clechasseur/rs-cargo.

Since I also forked the core repository and updated it, I plan on forking some other Actions (notably clippy-check). Probably not toolchain since that seems to be covered well enough already.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

No branches or pull requests

4 participants