Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARC not working with an organization whose name ends in hyphen #3663

Open
4 tasks done
and-es opened this issue Jul 16, 2024 · 2 comments · May be fixed by #3664
Open
4 tasks done

ARC not working with an organization whose name ends in hyphen #3663

and-es opened this issue Jul 16, 2024 · 2 comments · May be fixed by #3664
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers

Comments

@and-es
Copy link

and-es commented Jul 16, 2024

Checks

Controller Version

0.9.3

Deployment Method

Helm

Checks

  • This isn't a question or user support case (For Q&A and community support, go to Discussions).
  • I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

Follow Quickstart guide(https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/quickstart-for-actions-runner-controller) with an organization named "camphor-".
githubConfigUrl is "https://github.com/camphor-".

Describe the bug

Failed to create a runner scale set.
The controller log says:

"error": "AutoscalingRunnerSet.actions.github.com \"arc-runner-set\" is invalid: metadata.labels: Invalid value: \"camphor-\": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')"}

Describe the expected behavior

Create a runner scale set successfully.

Additional Context

Nothing. I just follow the quickstart guide.

Controller Logs

https://gist.github.com/and-es/1456bf907dd2ddc1716881ce6a2e1224

Runner Pod Logs

No runner pods
@and-es and-es added bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers labels Jul 16, 2024
Copy link
Contributor

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

@and-es and-es linked a pull request Jul 16, 2024 that will close this issue
@and-es
Copy link
Author

and-es commented Jul 16, 2024

I sent PR. Please review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant