Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC] Button continuePropagation does not, in fact continue propagation #7370

Open
Faithfinder opened this issue Nov 14, 2024 · 2 comments
Open

Comments

@Faithfinder
Copy link

Faithfinder commented Nov 14, 2024

🖥️ Steps to Reproduce

https://stackblitz.com/edit/vitejs-vite-zwvwk7?file=src%2FApp.tsx

Version

1.4.1

What browsers are you seeing the problem on?

Chrome

What operating system are you using?

MacOS

@yihuiliao
Copy link
Member

There have been other discussions regarding this. I think the one that probably has the most information is #2100 but I'd recommend also taking a look at #6157 which includes a codesandbox with an example similar to yours. #4683 is the PR that added the continuePropagation which has some details about a case using onPress and continuePropagation with I think is what you are encountering.

@Faithfinder
Copy link
Author

Oh god, I see. So, continuePropagation has to be called in all onPress... handlers... That's a PITA, I don't know how I'd make my teammates remember that.

I'm all for no propagation being the default, but I should be able to easily revert to default HTML behavior when I want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants