New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Cluster default variables into tfvars #48

Open

florianbeu opened this issue Nov 25, 2022 · 1 comment

Labels

good first issue

Collaborator

florianbeu commented Nov 25, 2022 •

edited

Loading

Currently some of the used variables have defaults set to a certain Cluster.

https://github.com/adorsys/ops-k8s-bootstrap/blob/725e1169feaeada5acda6972f58e844d9d8d493e/nostalgic-poincare-cluster/variables.tf#L5

https://github.com/adorsys/ops-k8s-bootstrap/blob/725e1169feaeada5acda6972f58e844d9d8d493e/nostalgic-poincare-cluster/variables.tf#L12

It should be moved to a tfvars file that every project can use its own cluster settings and does not use the wrong cluster id by default.

To use the tfvars the pipeline needs some adjustment to use the new tfvars file

https://github.com/adorsys/ops-k8s-bootstrap/blob/725e1169feaeada5acda6972f58e844d9d8d493e/.github/workflows/pr.yml#L70

https://github.com/adorsys/ops-k8s-bootstrap/blob/725e1169feaeada5acda6972f58e844d9d8d493e/.github/workflows/apply.yml#L66

https://github.com/adorsys/ops-k8s-bootstrap/blob/725e1169feaeada5acda6972f58e844d9d8d493e/.github/workflows/apply.yml#L59

florianbeu added the good first issue label

Contributor

nce commented Nov 25, 2022

relates to #38

kimdre assigned kimdre and unassigned kimdre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment