-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more Lua libraries #246
Comments
Good point. We should also evaluate the consequences of adding these libraries:
|
What these libraries add to the making of a game outweights the consequences In my opinion. |
That's for sure! But it's important to gather factual data about the consequences of making such a change in order to make a more informed decision. |
Yes opinion is not all. Sadly I dont know how to gather the data to find out if it would be detrimental to the performance. Is there any way I can push this? |
We should look into sol2 and see how they implemented lua libraries. Are these libraries dynamic loaded? Are there any requirements to include these libs? Compatibility issues? Maybe having some profiling data about compilation time and runtime performance with/without these libs would be good to have too. We should document all that in the pull request adding these libraries to Overload. |
Is there any way I can help do that? |
For sure! You can do this investigation process, do the change first (include the libs), and measure the performance impact (compilation and runtime), and document all that 👌 |
using sol2? |
Overload is using sol2 for lua scripting yes |
ok ok got it but where do I start? |
Make the requested change in |
can you show me how I can do the change? |
Read the documentation of the |
will do! |
We should consider adding the following libraries to the
ScriptInterpreter.cpp
:sol::lib::package
sol::lib::coroutine
sol::lib::string
sol::lib::os
sol::lib::table
The text was updated successfully, but these errors were encountered: