Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test building all the publishable wheels on cibuildwheel updates #1186

Open
webknjaz opened this issue Oct 9, 2024 · 2 comments
Open

Test building all the publishable wheels on cibuildwheel updates #1186

webknjaz opened this issue Oct 9, 2024 · 2 comments
Assignees

Comments

@webknjaz
Copy link
Member

webknjaz commented Oct 9, 2024

I realized that auto-merging dependabot bumps of $sbj like #1185 relies on building a small subset of wheels. However, this is an important bit of infrastructure that might manifest incompatibilities during release, too late in the process.
We should modify the workflow to also build all the wheels when this action is updated in dependabot PRs.

@webknjaz webknjaz self-assigned this Oct 9, 2024
@trim21
Copy link

trim21 commented Oct 22, 2024

we can just let cibuildwheel run tests after it build wheel

https://cibuildwheel.pypa.io/en/stable/options/#testing

A way to do this may be, run tests with cibuildwheel, and a seprated job for cpython/pypy to run pure python version or yarl.

This will make ci simpler.

@webknjaz
Copy link
Member Author

@trim21 those are already integrated but excluded in some cases due to being very slow in some envs like emulated QEMU and alpine. More things run in the release pipeline, but not on PRs.
Honestly, I did not expect anyone else to look into it as I was planning to do some thinking myself regarding how I want this shaped, keeping the broader cross-project context in mind. I'm not lacking knowledge regarding how cibuildwheel works, being a member of the PyPA myself.
Thanks for your input, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants