Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate OpenAPI 2 spec for ADC API? #765

Open
schristley opened this issue Feb 26, 2024 · 4 comments
Open

deprecate OpenAPI 2 spec for ADC API? #765

schristley opened this issue Feb 26, 2024 · 4 comments
Milestone

Comments

@schristley
Copy link
Member

@bcorrie Any reason to keep the OpenAPI 2 spec now that we have the OpenAPI 3 spec? We aren't doing any consistency checking between the two so who knows if they even match...

@bcorrie
Copy link
Contributor

bcorrie commented Feb 26, 2024

The only reason I can think of is if any tools are using it and we want to keep it for backwards compatibility. We are not using it, but I could see how someone out there in the wild might be?

@schristley
Copy link
Member Author

The only reason I can think of is if any tools are using it and we want to keep it for backwards compatibility. We are not using it, but I could see how someone out there in the wild might be?

Right, which is even more worrisome in a way because checking consistency between API specs is much harder than for just the schema...

So one way to know is to get rid of it and see if anybody complains! ;-)

@schristley
Copy link
Member Author

I suppose the larger question is do we intend to deprecate at some point, and when is that point? There's nothing particularly special about the AIRR V2 release for the ADC API, but it is a new release so is a chance to do it if we want.

@schristley
Copy link
Member Author

I'll note that we might, though I'm still thinking about this, extract out the ADC API schemas into its own file. Essentially making that one part of the spec look somewhat like this:

components:
    schemas:
        $ref: 'adc-api-schema.yaml'

With two thoughts in mind. One is that for services like VDJServer that automate on the spec, it might be easier to support those extension fields like v_subgroup and such. And two, services like the AKC which may extend those schemas in some way for its own APIs.

@javh javh added this to the ADC 2.0 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants