Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine or restructure the files guide_miairr_ncbi.rst, manual_miairr_ncbi.rst, specification_miairr_ncbi.rst #805

Open
ustervbo opened this issue Oct 6, 2024 · 3 comments

Comments

@ustervbo
Copy link
Contributor

ustervbo commented Oct 6, 2024

guide_miairr_ncbi.rst gives an overview that isn't really reflected in manual_miairr_ncbi.rst. For instance, Is Step 2 in manual_miairr_ncbi.rst corresponds to step 5 in guide_miairr_ncbi.rst, which is described in greater detail in specification_miairr_ncbi.rst.

Step 4 in guide_miairr_ncbi.rst is not described at all? Knowing zenodo I can guess what is meant, what is unclear is what do I do with the doi - not until I reach 'Record header' in specification_miairr_ncbi.rst.

@ustervbo
Copy link
Contributor Author

ustervbo commented Oct 7, 2024

Random observations I didn't know where else to put:

  • D_segment is required for IgH, TRB, and TRD. What if the caller does not give the D segment back? In TRB is it very difficult to match because the germline sequence it is often very short
  • C_region is required. However, this is largely unknown if the starting materials is DNA. It can be extrapolated from the J-region but a) it is work for the depositor with seemingly low benefit, and b) if there is no way to flag is as theoretical or similar, it may inflate the presence of the current consensus C-region sequences

@javh
Copy link
Contributor

javh commented Oct 7, 2024

Both d_segment and c_region can be null (empty string), so required means the field needs to be present, but the user need not populate it if the data isn't available/relevant.

@ustervbo
Copy link
Contributor Author

ustervbo commented Oct 7, 2024

From the call: Rewrite from scratch. recommend to use GEO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants