Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing Folder path with music files #14

Open
RonOren opened this issue Sep 23, 2022 · 1 comment
Open

Passing Folder path with music files #14

RonOren opened this issue Sep 23, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers priority: medium medium priority task

Comments

@RonOren
Copy link
Contributor

RonOren commented Sep 23, 2022

I tried 2 different playlists (I know for 100% that for most of the tracks there's synced lyrics in spotify.

One couldn't find any lyrics:

Screenshot_20220923-112316_Termux.png

The other stopped at 80 tracks and spat this error:

Screenshot_20220923-113040_Termux.jpg

@akashrchandran akashrchandran added bug Something isn't working good first issue Good for newcomers priority: medium medium priority task labels Oct 4, 2022
@akashrchandran
Copy link
Owner

I tried 2 different playlists (I know for 100% that for most of the tracks there's synced lyrics in spotify.

They may not have title and album metadata. It ignores the file name.

syrics/syrics/core.py

Lines 134 to 135 in 1bdfeef

tag = TinyTag.get(os.path.join(path, files))
query = client.search(q=f"track:{tag.title} album:{tag.album}", type="track", limit=1)

I will add fall back to file name if metadata is unavailable. Will also add search using ISRC tag (if exists), the result will be more accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers priority: medium medium priority task
Projects
None yet
Development

No branches or pull requests

2 participants