-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tagging with the highest version does NOT work as expected even after useHighestVersion = true is configured #662
Comments
Hallo All, This has worked for us in older versions of the plugin. If you agree, I'll try to fix it. Greetings, Tom |
Thanks for getting back on this issue @duschata - it would be great to have this fixed and controlled via the unit test verification going forward. |
@adamdubiel, @bgalek, |
Hi, thanks for providing a test case. This indeed seems like regression. I'll be happy to review and merge PR if you want to make a fix :) |
Hi All,
Could you please have a look and advise what may have been set up in wrong way in the following Axion plugin configuration as the expectation I'd had was the plugin to traverse the entire Git repo tree when working out the current position for a given "prefix" value?
The promise from the docs presumes that "
Tag with the highest version
Second mode is searching for highest version visible in the git tree's history. This means that all commits from HEAD till first commit will be analysed." (https://axion-release-plugin.readthedocs.io/en/latest/configuration/version/#tag-with-the-highest-version)
Repo state is similar to the example from docs:
[T1]
~|
| ~~ |
[] ~~ [T2]
| ~~ ~ |
[C] ~~~[]
Config applied:
scmVersion {
useHighestVersion = true
checks {
uncommittedChanges.set(false)
}
tag {
prefix.set(project.name.concat('-'))
}
repository {
directory.set(project.rootProject.layout.getProjectDirectory().toString())
pushTagsOnly.set(true)
}
}
Expected result of the "currentVersion" task:
Project version: {T2 + increment}-SNAPSHOT
Actual result of the "currentVersion" task:
Project version: {T1 + increment}-SNAPSHOT
The implication of this issue is that the current position value becomes dependent on which branch the "currentVersion" task is run from as well as failures in releasing new artifacts since this may lead to the new version generated by plugin clashing with what already tagged on other branches' commits.
Thanks.
The text was updated successfully, but these errors were encountered: