Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraint changes should be auditable #1905

Open
szczygiel-m opened this issue Sep 30, 2024 · 4 comments
Open

Constraint changes should be auditable #1905

szczygiel-m opened this issue Sep 30, 2024 · 4 comments

Comments

@szczygiel-m
Copy link
Contributor

We would like the form for adding constraints to include an additional text field “reason” whose purpose would be to hold a description of why the constraint was added.

@adriansobolewski
Copy link
Contributor

Does "constraints" refer to Workload constraints management?

@szczygiel-m
Copy link
Contributor Author

Does "constraints" refer to Workload constraints management?

Hi, actually it refers to topic/subscription constraint which is set usually by hermes admin to add more consumers and processing power for lagging subscription. This is the endpoint for this feature 😄

@adriansobolewski
Copy link
Contributor

adriansobolewski commented Oct 4, 2024

I'd like to work on this task then :)

I also have some clarifying questions:

  1. Should the new reason field be required and not blank?
  2. Do you have in mind some upper bound for the text length? Does 512 characters sound reasonable? :)
  3. Is this endpoint also used by some GUI layer and frontend needs to be adjusted as well?

@szczygiel-m
Copy link
Contributor Author

Great to hear that :)

  1. hmm, I think It will be ok if this field would not be required, we wouldn't want to break any external users integration with this feature.
  2. No, but 512 chars seems ok, i think that we can go even for 1024 chars :)
  3. Yes, it is used by gui, You can check it out by running hermes-console as described in readme, and then go to admin tools -> constraints
    image
    In case of any problems or further questions - feel free to ask :)

szczygiel-m added a commit that referenced this issue Nov 17, 2024
* 1905 | Added reason field to subscription and topic constratints on backend.

* 1905 | Added reason field to subscription and topic constratints on frontend.

* 1905 | Added missing unit test for topic constraints validations.

---------

Co-authored-by: Mateusz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants