Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] altair-plugin-fastify doesn't work with fastify v5 #2663

Closed
1 task done
xoldd opened this issue Sep 29, 2024 · 2 comments · Fixed by #2669
Closed
1 task done

[BUG] altair-plugin-fastify doesn't work with fastify v5 #2663

xoldd opened this issue Sep 29, 2024 · 2 comments · Fixed by #2669

Comments

@xoldd
Copy link

xoldd commented Sep 29, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

altair-fastify-plugin package doesn't work with the newly released fastify v5, the problem being the @fastify/static package used in altair-fastify-plugin package which only supports up to fastify v4

upgrading @fastify/static to the latest version should fix the problem, though it would be better to upgrade all fastify related packages used in altair-fastify-plugin package for long term future proofing

Expected Behavior

ideally altair-fastify-plugin package should work with fastify v5 and the previous fastify versions if there haven't been major changes in fastify's exposed apis

Steps To Reproduce

Follow the guide at this link and make sure to install fastify v5.

Environment

- OS: Fedora Linux 40
- Browser: Google Chrome
- Platform:
- Version: 7.3.6

Additional context

No response

@imolorhe
Copy link
Collaborator

Hey, thanks for reporting. Feel free to create a pull request with the necessary changes. Otherwise I'll pick this up as soon as I can.

@xoldd
Copy link
Author

xoldd commented Sep 29, 2024

@imolorhe i did try fixing it myself, but i faced errors related to yarn and was unable to set up the project locally on my system, as long as yarn doesn't work the yarn.lock file won't sync with the changes in the altair-fastify-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants