Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich text for topic description and node notes #397

Open
keyserj opened this issue Apr 25, 2024 · 0 comments
Open

Rich text for topic description and node notes #397

keyserj opened this issue Apr 25, 2024 · 0 comments
Labels
clarity makes something easier to understand convenient makes the tool easier to use enhancement New feature or request QoL small change the improves the feel of using the tool

Comments

@keyserj
Copy link
Collaborator

keyserj commented Apr 25, 2024

Describe your issue

When I'm creating a topic, sometimes in the topic description I

  • add links, and it'd be nice if they were clickable, or if I could put a link behind some display text
  • describe lists of things, so using bullets or numbers would be nice too

Links probably shouldn't be necessary for node notes (because of source nodes) but bullets and numbers could be nice.

Solution you'd like

Use a rich text box for topic description and node notes.

This is almost completely prototyped already in de3b67f

Alternatives you've considered

No response

Additional context

No response

Technical ideas and questions

  • does html need to be sanitized before being rendered into the editor?
    • does tiptap do any sanitization?
    • would it be best to convert html to markdown before saving in the database, to avoid harmful things (scripts?) being rendered into the editor?
  • will the text box re-render and flicker every time pane is opened? (during prototyping with node text it seemed like this happened)
    • could just leave this as a bug and try to fix later
@keyserj keyserj added enhancement New feature or request QoL small change the improves the feel of using the tool clarity makes something easier to understand convenient makes the tool easier to use labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarity makes something easier to understand convenient makes the tool easier to use enhancement New feature or request QoL small change the improves the feel of using the tool
Projects
Status: No status
Development

No branches or pull requests

1 participant