You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a continuation of #4358 where the same problem applied to amp-facebook and was fixed.
The premise is that these amp-* objects should be in the root of the document, and not be wrapped in <p> tags. Twitter already worked this way, and in #4358amp-facebook was fixed to match.
I've now noticed that amp-iframe, amp-instagram, amp-youtube, amp-soundcloud face the same problem:
As with the previous ticket, it's important to me because I need to style something that immediately follows the object (amp-instagram+.translation), but also generally it just seems like good practice all around.
Instagram embed code:
[embed]https://www.instagram.com/p/Buq8vU6Hcxn/[/embed]
<blockquote class="translation">This is a translation of the Instagram post above.</blockquote>
YouTube embed code
[embed]https://www.youtube.com/watch?v=vXPJVwwEmiM[/embed]
<blockquote class="translation">This is a translation of the YouTube video above.</blockquote>
jerclarke
changed the title
amp-instagram and amp-youtube wrapped in unnecessary p tag
amp-instagram, amp-youtube, amp-soundcloud wrapped in unnecessary p tags
Mar 26, 2020
Just here to say, would still be great to get this consistent!
Also noticed that this also applies to amp-iframe, which affects Tumblr and Mastodon 😅
jerclarke
changed the title
amp-instagram, amp-youtube, amp-soundcloud wrapped in unnecessary p tags
amp-iframe, amp-instagram, amp-youtube, amp-soundcloud wrapped in unnecessary p tags
Feb 2, 2023
Bug Description
This is a continuation of #4358 where the same problem applied to
amp-facebook
and was fixed.The premise is that these
amp-*
objects should be in the root of the document, and not be wrapped in<p>
tags. Twitter already worked this way, and in #4358amp-facebook
was fixed to match.I've now noticed that
amp-iframe
,amp-instagram
,amp-youtube
,amp-soundcloud
face the same problem:As with the previous ticket, it's important to me because I need to style something that immediately follows the object (
amp-instagram+.translation
), but also generally it just seems like good practice all around.Instagram embed code:
YouTube embed code
Soundcloud embed code
Mostly likely this applies to other embeds as well. A general review would be greatly appreciated.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: