Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: cannot review code and run no error #95

Open
guguducken opened this issue May 26, 2023 · 6 comments
Open

bug: cannot review code and run no error #95

guguducken opened this issue May 26, 2023 · 6 comments

Comments

@guguducken
Copy link

guguducken commented May 26, 2023

hello, I have some question when i use this action to review my code in pr, the workflow is success and no any logs, but not any review message appear in my pr, this is why?
link: https://github.com/matrixorigin/matrixone/actions/runs/5089548569/jobs/9147314734
help(。ì _ í。)@anc95

@anc95
Copy link
Owner

anc95 commented May 26, 2023

@guguducken Could you please use the latest version v1.0.7? I have added some logs to explain why the review did not succeed.

@guguducken
Copy link
Author

@guguducken Could you please use the latest version v1.0.7? I have added some logs to explain why the review did not succeed.

I use version v1.0.7 in my private repo, it output the same result.
image
did I make configure error in somewhere?
image

@guguducken
Copy link
Author

@anc95
Copy link
Owner

anc95 commented May 26, 2023

@guguducken hey, I see that you configured the if:, it's optional, please remove it and try again.

@fedealconada
Copy link

fedealconada commented Jun 28, 2023

i'm trying to make it work with the if: but seems like it does not...

@guguducken
Copy link
Author

sorry for reply so late, this is a bug,the reason is the trigger event is pull_request but that cannot read secrets, so I use pull_request_target to replace it. And this action cannot get the pull_request_target event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@fedealconada @anc95 @guguducken and others