You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
md-colors directive throws error when property values evaluate to null or undefined.
Handling null or undefined is particularly useful when expression is controlled by some nullable user input.
Currently it not logs an error in the console, but also fails to correctly clean previous styles when going from some value to undefined or null.
md-colors should gracefully handle null or undefined. It should not log error in the console, and also it should clean previous styles when going from a valid color to null/undefined
What is the current behavior?
It logs lots of errors in the console and doesn't clean previous styles properly.
What is the use-case or motivation for changing an existing behavior?
All use cases when values are not static strings and are dynamically evaluated and can may be nullable.
Which versions of AngularJS, Material, OS, and browsers are affected?
AngularJS: any (not relevant)
AngularJS Material: 1.1.13 (latest at the time)
OS: any
Browsers: any
Is there anything else we should know? Stack Traces, Screenshots, etc.
No
The text was updated successfully, but these errors were encountered:
Bug or maybe enhancement request:
md-colors
directive throws error when property values evaluate to null or undefined.Handling null or undefined is particularly useful when expression is controlled by some nullable user input.
Currently it not logs an error in the console, but also fails to correctly clean previous styles when going from some value to undefined or null.
CodePen and steps to reproduce the issue:
CodePen Demo which demonstrates the issue:
Detailed Reproduction Steps:
What is the expected behavior?
md-colors
should gracefully handlenull
orundefined
. It should not log error in the console, and also it should clean previous styles when going from a valid color tonull
/undefined
What is the current behavior?
It logs lots of errors in the console and doesn't clean previous styles properly.
What is the use-case or motivation for changing an existing behavior?
All use cases when values are not static strings and are dynamically evaluated and can may be nullable.
Which versions of AngularJS, Material, OS, and browsers are affected?
Is there anything else we should know? Stack Traces, Screenshots, etc.
No
The text was updated successfully, but these errors were encountered: