Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverless config flag is not supported #8739

Open
1 task done
jgiacobbi opened this issue Aug 10, 2024 · 1 comment
Open
1 task done

Serverless config flag is not supported #8739

jgiacobbi opened this issue Aug 10, 2024 · 1 comment
Labels
feature This issue/PR relates to a feature request module module needs_maintainer plugins plugin (any type)

Comments

@jgiacobbi
Copy link

Summary

Nothing complicated, the config flag is missing so to use this module you are required to use the default serverless path or find some workaround. I am currently juggling symlinks.

https://www.serverless.com/framework/docs/providers/aws/cli-reference/deploy

Issue Type

Feature Idea

Component Name

serverless

Additional Information

I already implemented the feature. You can view my implementation here: Comparison

I tried to respect the prevailing style. I ran the sanity checks. Please let me know if I missed anything or if something should be different. This should not be a breaking change. I chose to use serverless.yml as the default parameter instead of '' because it most closely matches the existing behavior.

I tested the behavior locally:

main:

TASK [Deploy redacted stack] **************************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (community.general.serverless) module: config. Supported parameters include: deploy, force, region, serverless_bin_path, service_path, stage, state, verbose."}

my branch:

TASK [debug] ************************************************************************************************************************
ok: [localhost] => {
    "sls": {
        "changed": true,
        "command": "/root/.serverless/bin/serverless deploy --config serverless-nonstandard-path.yml --stage dev ",
        "failed": false,
        "out": "\n",
        "service_name": "service-dev",
        "state": "present"
    }
}

If there are no objections I will open a pull request and add a changelog snippet.

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibullbot
Copy link
Collaborator

Files identified in the description:

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_maintainer plugins plugin (any type) labels Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request module module needs_maintainer plugins plugin (any type)
Projects
None yet
Development

No branches or pull requests

2 participants