From 83749b6542fad18a99e4271fc9a27ef6e008246a Mon Sep 17 00:00:00 2001 From: David Li Date: Thu, 5 Sep 2024 21:05:50 -0400 Subject: [PATCH] chore(ci): stop building for Python 3.8 Fixes #2129. --- .env | 2 +- .github/workflows/packaging.yml | 22 +------------------- ci/scripts/install_python.sh | 3 +-- ci/scripts/python_util.sh | 3 ++- dev/release/verify-release-candidate.sh | 4 ++-- python/adbc_driver_bigquery/pyproject.toml | 2 +- python/adbc_driver_flightsql/pyproject.toml | 2 +- python/adbc_driver_manager/pyproject.toml | 2 +- python/adbc_driver_postgresql/pyproject.toml | 2 +- python/adbc_driver_snowflake/pyproject.toml | 2 +- python/adbc_driver_sqlite/pyproject.toml | 2 +- 11 files changed, 13 insertions(+), 33 deletions(-) diff --git a/.env b/.env index 31b390ab58..c2ed465e49 100644 --- a/.env +++ b/.env @@ -32,7 +32,7 @@ JDK=8 MANYLINUX=2014 MAVEN=3.6.3 PLATFORM=linux/amd64 -PYTHON=3.8 +PYTHON=3.9 GO=1.21.8 ARROW_MAJOR_VERSION=14 DOTNET=8.0 diff --git a/.github/workflows/packaging.yml b/.github/workflows/packaging.yml index 7bf5f90b91..c33d027752 100644 --- a/.github/workflows/packaging.yml +++ b/.github/workflows/packaging.yml @@ -616,14 +616,6 @@ jobs: adbc/python/adbc_driver_sqlite/repaired_wheels/*.whl adbc/python/adbc_driver_snowflake/repaired_wheels/*.whl - - name: Test wheel 3.8 - env: - ARCH: ${{ matrix.arch }} - PLATFORM: ${{ matrix.platform }} - run: | - pushd adbc - env PYTHON=3.8 docker compose run python-wheel-manylinux-test - - name: Test wheel 3.9 env: ARCH: ${{ matrix.arch }} @@ -728,11 +720,10 @@ jobs: if: matrix.arch == 'amd64' run: | pushd adbc - sudo ci/scripts/install_python.sh macos 3.8 sudo ci/scripts/install_python.sh macos 3.9 popd - - name: Install Python (AMD64 only) + - name: Install Python run: | pushd adbc sudo ci/scripts/install_python.sh macos 3.10 @@ -762,17 +753,6 @@ jobs: adbc/python/adbc_driver_sqlite/repaired_wheels/*.whl adbc/python/adbc_driver_snowflake/repaired_wheels/*.whl - - name: Test wheel 3.8 - if: matrix.arch == 'amd64' - run: | - pushd adbc - - /Library/Frameworks/Python.framework/Versions/3.8/bin/python3.8 -m venv test-env-38 - source test-env-38/bin/activate - export PYTHON_VERSION=3.8 - ./ci/scripts/python_wheel_unix_test.sh $(pwd) - deactivate - - name: Test wheel 3.9 if: matrix.arch == 'amd64' run: | diff --git a/ci/scripts/install_python.sh b/ci/scripts/install_python.sh index 8eda08fe78..8f19d00171 100755 --- a/ci/scripts/install_python.sh +++ b/ci/scripts/install_python.sh @@ -27,8 +27,7 @@ platforms=([windows]=Windows [linux]=Linux) declare -A versions -versions=([3.8]=3.8.10 - [3.9]=3.9.13 +versions=([3.9]=3.9.13 [3.10]=3.10.11 [3.11]=3.11.8 [3.12]=3.12.2) diff --git a/ci/scripts/python_util.sh b/ci/scripts/python_util.sh index a4c38b9ba8..5be89e798e 100644 --- a/ci/scripts/python_util.sh +++ b/ci/scripts/python_util.sh @@ -136,7 +136,8 @@ function setup_build_vars { export CIBW_BUILD='*-manylinux_*' export CIBW_PLATFORM="linux" fi - export CIBW_SKIP="pp* ${CIBW_SKIP}" + # No PyPy, no Python 3.8 + export CIBW_SKIP="pp* cp38-* ${CIBW_SKIP}" } function test_packages { diff --git a/dev/release/verify-release-candidate.sh b/dev/release/verify-release-candidate.sh index bc69948d49..f071146c41 100755 --- a/dev/release/verify-release-candidate.sh +++ b/dev/release/verify-release-candidate.sh @@ -825,7 +825,7 @@ test_linux_wheels() { local arch="x86_64" fi - local python_versions="${TEST_PYTHON_VERSIONS:-3.9 3.10 3.11}" + local python_versions="${TEST_PYTHON_VERSIONS:-3.9 3.10 3.11 3.12}" for python in ${python_versions}; do local pyver=${python/m} @@ -847,7 +847,7 @@ test_macos_wheels() { local platform_tags="x86_64" fi - local python_versions="${TEST_PYTHON_VERSIONS:-3.9 3.10 3.11}" + local python_versions="${TEST_PYTHON_VERSIONS:-3.9 3.10 3.11 3.12}" # verify arch-native wheels inside an arch-native conda environment for python in ${python_versions}; do diff --git a/python/adbc_driver_bigquery/pyproject.toml b/python/adbc_driver_bigquery/pyproject.toml index 405d641370..364118b7b9 100644 --- a/python/adbc_driver_bigquery/pyproject.toml +++ b/python/adbc_driver_bigquery/pyproject.toml @@ -21,7 +21,7 @@ description = "An ADBC driver for working with BigQuery." authors = [{name = "Apache Arrow Developers", email = "dev@arrow.apache.org"}] license = {text = "Apache-2.0"} readme = "README.md" -requires-python = ">=3.8" +requires-python = ">=3.9" dynamic = ["version"] dependencies = [ "adbc-driver-manager", diff --git a/python/adbc_driver_flightsql/pyproject.toml b/python/adbc_driver_flightsql/pyproject.toml index c7de2df106..46be498414 100644 --- a/python/adbc_driver_flightsql/pyproject.toml +++ b/python/adbc_driver_flightsql/pyproject.toml @@ -21,7 +21,7 @@ description = "An ADBC driver for working with Apache Arrow Flight SQL." authors = [{name = "Apache Arrow Developers", email = "dev@arrow.apache.org"}] license = {text = "Apache-2.0"} readme = "README.md" -requires-python = ">=3.8" +requires-python = ">=3.9" dynamic = ["version"] dependencies = [ "adbc-driver-manager", diff --git a/python/adbc_driver_manager/pyproject.toml b/python/adbc_driver_manager/pyproject.toml index a8b1b130a5..16f7d00eed 100644 --- a/python/adbc_driver_manager/pyproject.toml +++ b/python/adbc_driver_manager/pyproject.toml @@ -21,7 +21,7 @@ description = "A generic entrypoint for ADBC drivers." authors = [{name = "Apache Arrow Developers", email = "dev@arrow.apache.org"}] license = {text = "Apache-2.0"} readme = "README.md" -requires-python = ">=3.8" +requires-python = ">=3.9" dynamic = ["version"] dependencies = ["typing-extensions"] diff --git a/python/adbc_driver_postgresql/pyproject.toml b/python/adbc_driver_postgresql/pyproject.toml index 8eb48e2ad4..9170e75394 100644 --- a/python/adbc_driver_postgresql/pyproject.toml +++ b/python/adbc_driver_postgresql/pyproject.toml @@ -21,7 +21,7 @@ description = "A libpq-based ADBC driver for working with PostgreSQL." authors = [{name = "Apache Arrow Developers", email = "dev@arrow.apache.org"}] license = {text = "Apache-2.0"} readme = "README.md" -requires-python = ">=3.8" +requires-python = ">=3.9" dynamic = ["version"] dependencies = [ "adbc-driver-manager", diff --git a/python/adbc_driver_snowflake/pyproject.toml b/python/adbc_driver_snowflake/pyproject.toml index 492e1bb024..406938677e 100644 --- a/python/adbc_driver_snowflake/pyproject.toml +++ b/python/adbc_driver_snowflake/pyproject.toml @@ -21,7 +21,7 @@ description = "An ADBC driver for working with Snowflake." authors = [{name = "Apache Arrow Developers", email = "dev@arrow.apache.org"}] license = {text = "Apache-2.0"} readme = "README.md" -requires-python = ">=3.8" +requires-python = ">=3.9" dynamic = ["version"] dependencies = [ "adbc-driver-manager", diff --git a/python/adbc_driver_sqlite/pyproject.toml b/python/adbc_driver_sqlite/pyproject.toml index 6904b69733..b773665a92 100644 --- a/python/adbc_driver_sqlite/pyproject.toml +++ b/python/adbc_driver_sqlite/pyproject.toml @@ -21,7 +21,7 @@ description = "An ADBC driver for working with SQLite." authors = [{name = "Apache Arrow Developers", email = "dev@arrow.apache.org"}] license = {text = "Apache-2.0"} readme = "README.md" -requires-python = ">=3.8" +requires-python = ">=3.9" dynamic = ["version"] dependencies = [ "adbc-driver-manager",